docs(qdrant): sync template standards updates#351
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughAdds a Network Policy configuration section to the qdrant playground config, expands Qdrant chart documentation with egress and network policy details, and adds qdrant to the site-synced playground chart list. ChangesQdrant Network Policy Support
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
Author
|
Synced the Qdrant NetworkPolicy docs with helmforgedev/charts#673. What changed:
Validation:
|
mberlofa
added a commit
to helmforgedev/charts
that referenced
this pull request
Jul 6, 2026
## Summary - Align StatefulSet pod template labels with immutable selector labels plus user `podLabels`. - Guard empty `ingress.ingressClassName` rendering. - Move validation into the canonical `qdrant.validate` helper and add validations for ingress hosts plus selector-label podLabels overrides. - Add `networkPolicy.extraEgress` support with DNS, HTTPS, and distributed p2p baseline egress rules before user rules. - Align `NOTES.txt` with numbered HelmForge operational sections. ## Validation - `helm unittest charts/qdrant`: 28 tests passed - `helm lint --strict charts/qdrant`: passed - `make template-standards-check CHART=qdrant`: passed - `make standards-check CHART=qdrant`: passed - `make standards-guard CHART=qdrant`: passed - `make site-sync-check CHART=qdrant`: passed - `npm run lint`: passed in site repo - `npm run format:check`: passed in site repo - `npm run build`: passed in site repo - `node scripts/charts/validate-chart.js --chart qdrant --no-k3d`: all local layers passed except the known local remote schema download failure from `raw.githubusercontent.com` - Strict kubeconform rerun with local official schemas: default plus every `ci/*.yaml` passed with `Skipped: 0` - k3d behavioral validation on `k3d-helmforge-tests-wsl`: default plus every `ci/*.yaml` passed sequentially - `make release-check REPO=charts`: passed with expected post-merge release warning - `make attribution-check REPO=charts`: passed ## Site Sync Site PR: helmforgedev/site#351 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added documentation for network policy, including inbound restrictions and optional egress isolation via `extraEgress` (with example). * Added support for `networkPolicy.extraEgress` in chart configuration and schema. * Improved post-deploy operator runbook with expanded checks and guidance. * **Bug Fixes / Improvements** * Ingress now sets `ingressClassName` only when configured. * Added stricter Helm chart validation for invalid value combinations and label overrides. * **Tests** * Expanded network policy and validation coverage, including egress-isolation behavior and new ingress/label validation cases. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: MergeCheck <mergecheck@example.invalid>
dac492f to
d9aee39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
networkPolicy.extraEgressfor the Qdrant chart.Related
Chart PR: helmforgedev/charts#673
Validation
make site-sync-check CHART=qdrant: passednpm run lint: passednpm run format:check: passednpm run build: passedmake release-check REPO=site: passedmake attribution-check REPO=site: passedSummary by CodeRabbit
New Features
Documentation
networkPolicy.extraEgress, including how network restrictions interact with cluster and peer communication.