Skip to content

docs(qdrant): sync template standards updates#351

Merged
mberlofa merged 2 commits into
mainfrom
docs/qdrant-template-standards-sync
Jul 6, 2026
Merged

docs(qdrant): sync template standards updates#351
mberlofa merged 2 commits into
mainfrom
docs/qdrant-template-standards-sync

Conversation

@mberlofa

@mberlofa mberlofa commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Document networkPolicy.extraEgress for the Qdrant chart.
  • Add the Qdrant NetworkPolicy controls to the playground config.
  • Register Qdrant as a required playground config for site sync.

Related

Chart PR: helmforgedev/charts#673

Validation

  • make site-sync-check CHART=qdrant: passed
  • npm run lint: passed
  • npm run format:check: passed
  • npm run build: passed
  • make release-check REPO=site: passed
  • make attribution-check REPO=site: passed

Summary by CodeRabbit

  • New Features

    • Added a “Network Policy” section to the Qdrant playground configuration, enabling ingress namespace filtering and optional extra egress (destination CIDR and TCP port).
    • Included Qdrant in the site-synced playground charts list so it’s properly included in playground filtering and syncing.
  • Documentation

    • Updated Qdrant chart docs with a production egress example and clearer guidance on networkPolicy.extraEgress, including how network restrictions interact with cluster and peer communication.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ba2be7b2-9ffb-4a3b-994d-3a1f1f721548

📥 Commits

Reviewing files that changed from the base of the PR and between dac492f and d9aee39.

📒 Files selected for processing (3)
  • src/data/playground-configs.ts
  • src/pages/docs/charts/qdrant.mdx
  • src/pages/playground.astro
✅ Files skipped from review due to trivial changes (1)
  • src/pages/docs/charts/qdrant.mdx
🚧 Files skipped from review as they are similar to previous changes (2)
  • src/data/playground-configs.ts
  • src/pages/playground.astro

📝 Walkthrough

Walkthrough

Adds a Network Policy configuration section to the qdrant playground config, expands Qdrant chart documentation with egress and network policy details, and adds qdrant to the site-synced playground chart list.

Changes

Qdrant Network Policy Support

Layer / File(s) Summary
Network Policy playground config fields
src/data/playground-configs.ts
Adds a Network Policy section to the qdrant playground config, gated by networkPolicy.enabled, with fields for ingress namespace selector, extra egress CIDR, and extra egress port with defaults.
Playground site-sync registration
src/pages/playground.astro
Adds qdrant to siteSyncPlaygroundConfigs so it is treated as site-synced in playground chart filtering.
Qdrant documentation updates
src/pages/docs/charts/qdrant.mdx
Adds an extraEgress YAML example, expands the networkPolicy.extraEgress Runtime Values description, and adds a new "Network Policy" section explaining ingress restriction and egress isolation behavior.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • helmforgedev/site#330: Modifies src/pages/playground.astro’s siteSyncPlaygroundConfigs, affecting the same playground chart filtering path.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers summary and validation, but it omits the template's Quality Gates checklist and Related Issue section. Add the Quality Gates checkbox list and a Related Issue line in the template format, and include the issue number if applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and matches the main change: syncing Qdrant docs and playground config updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/qdrant-template-standards-sync

Comment @coderabbitai help to get the list of available commands.

@mberlofa

mberlofa commented Jul 5, 2026

Copy link
Copy Markdown
Contributor Author

Synced the Qdrant NetworkPolicy docs with helmforgedev/charts#673.

What changed:

  • Clarified that networkPolicy.extraEgress enables egress isolation while preserving DNS and broad HTTPS egress to any IPv4/IPv6 destination before appending custom egress rules.

Validation:

  • npm run format:check passed.
  • npm run lint passed.
  • npm run build passed.
  • make release-check REPO=site passed.
  • make attribution-check REPO=site passed.

mberlofa added a commit to helmforgedev/charts that referenced this pull request Jul 6, 2026
## Summary

- Align StatefulSet pod template labels with immutable selector labels
plus user `podLabels`.
- Guard empty `ingress.ingressClassName` rendering.
- Move validation into the canonical `qdrant.validate` helper and add
validations for ingress hosts plus selector-label podLabels overrides.
- Add `networkPolicy.extraEgress` support with DNS, HTTPS, and
distributed p2p baseline egress rules before user rules.
- Align `NOTES.txt` with numbered HelmForge operational sections.

## Validation

- `helm unittest charts/qdrant`: 28 tests passed
- `helm lint --strict charts/qdrant`: passed
- `make template-standards-check CHART=qdrant`: passed
- `make standards-check CHART=qdrant`: passed
- `make standards-guard CHART=qdrant`: passed
- `make site-sync-check CHART=qdrant`: passed
- `npm run lint`: passed in site repo
- `npm run format:check`: passed in site repo
- `npm run build`: passed in site repo
- `node scripts/charts/validate-chart.js --chart qdrant --no-k3d`: all
local layers passed except the known local remote schema download
failure from `raw.githubusercontent.com`
- Strict kubeconform rerun with local official schemas: default plus
every `ci/*.yaml` passed with `Skipped: 0`
- k3d behavioral validation on `k3d-helmforge-tests-wsl`: default plus
every `ci/*.yaml` passed sequentially
- `make release-check REPO=charts`: passed with expected post-merge
release warning
- `make attribution-check REPO=charts`: passed

## Site Sync

Site PR: helmforgedev/site#351

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Added documentation for network policy, including inbound restrictions
and optional egress isolation via `extraEgress` (with example).
* Added support for `networkPolicy.extraEgress` in chart configuration
and schema.
* Improved post-deploy operator runbook with expanded checks and
guidance.

* **Bug Fixes / Improvements**
  * Ingress now sets `ingressClassName` only when configured.
* Added stricter Helm chart validation for invalid value combinations
and label overrides.

* **Tests**
* Expanded network policy and validation coverage, including
egress-isolation behavior and new ingress/label validation cases.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: MergeCheck <mergecheck@example.invalid>
@mberlofa mberlofa force-pushed the docs/qdrant-template-standards-sync branch from dac492f to d9aee39 Compare July 6, 2026 14:15
@mberlofa mberlofa merged commit 238bfc5 into main Jul 6, 2026
6 checks passed
@mberlofa mberlofa deleted the docs/qdrant-template-standards-sync branch July 6, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant